XN137 commented on code in PR #2015: URL: https://github.com/apache/polaris/pull/2015#discussion_r2195358611
########## polaris-core/src/main/java/org/apache/polaris/core/config/RealmConfigImpl.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.config; + +import jakarta.annotation.Nullable; +import org.apache.polaris.core.context.RealmContext; +import org.apache.polaris.core.entity.CatalogEntity; + +public class RealmConfigImpl implements RealmConfig { + + private final PolarisConfigurationStore configurationStore; Review Comment: the idea of having the interface is to make the life of the callers easier as they most often (/always?) operate in the context of a single realm / `CallContext`. whether configuration values are stored by a single store for all/multiple realms or not is an implementation detail that caller should not have to care about. so afaict `PolarisConfigurationStore` can keep its current implementation unless in the future we notice any advantages of splitting it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
