dimas-b commented on code in PR #2015:
URL: https://github.com/apache/polaris/pull/2015#discussion_r2196141034
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -82,11 +78,9 @@ public StorageCredentialCache(
/** How long credentials should remain in the cache. */
private long maxCacheDurationMs() {
var cacheDurationSeconds =
- configurationStore.getConfiguration(
- realmContext,
FeatureConfiguration.STORAGE_CREDENTIAL_CACHE_DURATION_SECONDS);
+
realmConfig.getConfig(FeatureConfiguration.STORAGE_CREDENTIAL_CACHE_DURATION_SECONDS);
Review Comment:
After reading the related but not changed code, I realised that
`StorageCredentialCache` is currently created and kept in-memory on a one
instance per realm basis. So the above statement is a non-issue until we make
`StorageCredentialCache` application-scoped. Sorry about the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
