XN137 commented on code in PR #2021:
URL: https://github.com/apache/polaris/pull/2021#discussion_r2197002985
##########
runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -465,7 +465,7 @@ public Supplier<TransactionalPersistence>
getOrCreateSessionSupplier(
@Override
public StorageCredentialCache
getOrCreateStorageCredentialCache(RealmContext realmContext) {
Review Comment:
i have a followup PR-2022 for dealing with this method, generally speaking
since `StorageCredentialCache` is application-scoped and multi-realm then this
method is no longer needed at all afaict.
its only getting called from a single place `RealmEntityManagerFactory` so
idk if deprecation would achieve much but i can add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
