XN137 commented on code in PR #2021:
URL: https://github.com/apache/polaris/pull/2021#discussion_r2197006317
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java:
##########
@@ -44,18 +42,13 @@ public class StorageCredentialCacheKey {
private final Set<String> allowedWriteLocations;
- /**
- * The callContext is passed to be used to fetch subscoped creds, but is not
used to hash/equals
- * as part of the cache key.
- */
- private @Nullable PolarisCallContext callContext;
Review Comment:
yes but also removal of the `realmContext` field is important as well, as it
is request scope but was being used inside the expiry logic of the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
