dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2198318843


##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
               type: string
               description: endpoint for STS requests (optional). If not set, 
defaults to 'endpoint'.
               example: "https://sts.example.com:1234";
+            pathStyleAccess:
+              type: boolean
+              description: >- 
+                Whether S3 requests to files in this catalog should use 
'path-style addressing for buckets'.
+                Default: false.

Review Comment:
   @eric-maynard : your previous comment made me realise that the new 
`AwsStorageConfigurationInfo` properties are not properly converted back to 
`AwsStorageConfigInfo` yet. I'll tackle that as a separate PR, if you do not 
mind.
   
   I'll convert `pathStyleAccess` to object `Boolean` in 
`AwsStorageConfigurationInfo` to ensure unset values are distinct from defaults 
(and thus do not affect older catalogs).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to