dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2198499673
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
I agree that we do not have a specific test for new property values in REST
responses. However, `CatalogSerializationTest` makes sure defaults in new
properties in `AwsStorageConfigInfo` do not show up in JSON.
As I mentioned above, we're missing code for new properties to be propagated
from `AwsStorageConfigurationInfo` to `AwsStorageConfigInfo`, so I cannot even
add a test for that without extra changes, which is what I'm proposing to do in
a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
