XN137 commented on code in PR #2176:
URL: https://github.com/apache/polaris/pull/2176#discussion_r2230221743
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -115,15 +113,12 @@ public String serialize() {
}
}
- public static @Nullable ConnectionConfigInfoDpo deserialize(
- @Nonnull PolarisDiagnostics diagnostics, final @Nonnull String jsonStr) {
+ public static ConnectionConfigInfoDpo deserialize(final @Nonnull String
jsonStr) {
try {
return DEFAULT_MAPPER.readValue(jsonStr, ConnectionConfigInfoDpo.class);
- } catch (JsonProcessingException exception) {
- diagnostics.fail(
- "fail_to_deserialize_connection_configuration", exception,
"jsonStr={}", jsonStr);
+ } catch (JsonProcessingException ex) {
+ throw new RuntimeException("deserialize failed", ex);
Review Comment:
i've added the message as you suggested.
iirc some lint tools flag this as a problem, as you are simply repeating the
same information.
also from my experience the jackson exceptions are often not very helpful if
you dont also have the exact JSON input to compare to (which i did not include
because i think properties could contain credentials etc.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
