dimas-b commented on code in PR #2176:
URL: https://github.com/apache/polaris/pull/2176#discussion_r2231995881
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java:
##########
@@ -115,15 +113,12 @@ public String serialize() {
}
}
- public static @Nullable ConnectionConfigInfoDpo deserialize(
- @Nonnull PolarisDiagnostics diagnostics, final @Nonnull String jsonStr) {
+ public static ConnectionConfigInfoDpo deserialize(final @Nonnull String
jsonStr) {
try {
return DEFAULT_MAPPER.readValue(jsonStr, ConnectionConfigInfoDpo.class);
- } catch (JsonProcessingException exception) {
- diagnostics.fail(
- "fail_to_deserialize_connection_configuration", exception,
"jsonStr={}", jsonStr);
+ } catch (JsonProcessingException ex) {
+ throw new RuntimeException("deserialize failed", ex);
Review Comment:
not "simply" repeating :) In some cases only the exception message is
available for debugging, while the full stack trace takes extra efforts to
obtain.
I'm fine either way, but thanks for addressing my nitpick :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
