dimas-b commented on code in PR #2196:
URL: https://github.com/apache/polaris/pull/2196#discussion_r2240335637
##########
runtime/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -43,6 +44,12 @@ public MetaStoreManagerFactory metaStoreManagerFactory(
return
metaStoreManagerFactories.select(Identifier.Literal.of(persistenceType)).get();
}
+ @Produces
+ @ApplicationScoped
+ public SchemaInitializer schemaInitializer(MetaStoreManagerFactory
metaStoreManagerFactory) {
+ return (SchemaInitializer) metaStoreManagerFactory;
Review Comment:
... but having those runtime errors is good, IMHO :) CDI errors should only
happen if the tool setup calls for a `SchemaInitializer` but the configuration
does not allow for an implementation to be found. All in all this would lead to
a clear error, whereas, a type case would lead to a very obscure error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
