dimas-b commented on code in PR #2196:
URL: https://github.com/apache/polaris/pull/2196#discussion_r2240346226
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/bootstrap/SchemaOptions.java:
##########
@@ -31,6 +32,17 @@ public interface SchemaOptions {
@Nullable
String schemaFile();
+ @Value.Default
+ default boolean setupSchema() {
+ return true;
+ }
+
+ @NotNull
+ @Value.Default
+ default String schemaName() {
+ return "POLARIS_SCHEMA";
Review Comment:
Isn't this kind of asymmetric now? `SchemaOptions` allow callers to set any
schema name, but persistence implementations do not use it for actually
creating the schema :thinking: ... or did I miss it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
