XN137 commented on code in PR #2304:
URL: https://github.com/apache/polaris/pull/2304#discussion_r2264586292
##########
runtime/service/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -53,7 +53,7 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
BatchFileCleanupTask cleanupTask =
task.readData(BatchFileCleanupTask.class);
TableIdentifier tableId = cleanupTask.tableId();
List<String> batchFiles = cleanupTask.batchFiles();
- try (FileIO authorizedFileIO = fileIOSupplier.apply(task, callContext)) {
+ try (FileIO authorizedFileIO = fileIOSupplier.apply(task, tableId,
callContext)) {
Review Comment:
it already contains that information, readable via `TaskEntity.readData`.
please provide a detailed suggestion of how you would want the `TaskEntity`
to hold the table identifier in a different way, as I am unable to comprehend
what you are asking for and how that would be an improvement.
`TaskEntity` is a `PolarisEntity` and thus afaict the only places where we
can add "new information" is in the `properties` or `internalProperties` fields
and `TaskEntity.readData` is already stored in the `properties` and holds the
`TableIdentifier` (for tasks that need it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
