eric-maynard commented on code in PR #2304:
URL: https://github.com/apache/polaris/pull/2304#discussion_r2268053685
##########
runtime/service/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -53,7 +53,7 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
BatchFileCleanupTask cleanupTask =
task.readData(BatchFileCleanupTask.class);
TableIdentifier tableId = cleanupTask.tableId();
List<String> batchFiles = cleanupTask.batchFiles();
- try (FileIO authorizedFileIO = fileIOSupplier.apply(task, callContext)) {
+ try (FileIO authorizedFileIO = fileIOSupplier.apply(task, tableId,
callContext)) {
Review Comment:
> without this PR task handlers are simply logging the wrong value because
it treats a TaskEntity as a IcebergTableLikeEntity and generates a wrong
TableIdentifier (pointing to the task entity, instead of the table).
Yes, this logic is definitely wrong -- but we should fix it to extract the
TASK_DATA and get the qualified table identifier from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
