poojanilangekar commented on code in PR #2301: URL: https://github.com/apache/polaris/pull/2301#discussion_r2268002481
########## polaris-core/src/main/java/org/apache/polaris/core/catalog/NonRESTCatalogFactory.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.catalog; + +import org.apache.iceberg.catalog.Catalog; +import org.apache.polaris.core.connection.ConnectionConfigInfoDpo; +import org.apache.polaris.core.secrets.UserSecretsManager; + +/** + * Factory interface for creating non-REST catalog handles based on connection configuration. + * + * <p>Implementations should be annotated with CDI annotations and use the @Identifier annotation to + * specify which connection type they support. + */ +public interface NonRESTCatalogFactory { Review Comment: Done. ########## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java: ########## @@ -219,7 +221,6 @@ protected void initializeCatalog() { Catalog federatedCatalog; ConnectionType connectionType = ConnectionType.fromCode(connectionConfigInfoDpo.getConnectionTypeCode()); - switch (connectionType) { case ICEBERG_REST: Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
