poojanilangekar commented on code in PR #2301:
URL: https://github.com/apache/polaris/pull/2301#discussion_r2271134608


##########
runtime/service/build.gradle.kts:
##########
@@ -30,6 +30,9 @@ dependencies {
   implementation(project(":polaris-api-management-service"))
   implementation(project(":polaris-api-iceberg-service"))
   implementation(project(":polaris-api-catalog-service"))
+  if ((project.findProperty("NonRESTCatalogs") as String?)?.contains("HADOOP") 
== true) {

Review Comment:
   I had that until 
https://github.com/apache/polaris/pull/2301/commits/c73966cda2d73396aeda70738b1b7133a545ba24
 
   
   I can do either, from the Polaris OSS sync last week (discussion about 
regarding hive federation), my takeaway was that we wanted to avoid having the 
default Polaris JAR depend on anything hadoop. 
   
   
   However, if you'd prefer compiling it each time (and only loading if 
necessary), I can revert that change. I will send out a separate PR without 
dynamic compilation and update a README.md for this PR. Please pick the option 
that's best suited according to you. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to