dennishuo commented on code in PR #2317:
URL: https://github.com/apache/polaris/pull/2317#discussion_r2271168766
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -427,43 +428,28 @@ public Page<EntityNameLookupRecord> listEntities(
long catalogId,
long parentId,
@Nonnull PolarisEntityType entityType,
+ @Nonnull PolarisEntitySubType entitySubType,
@Nonnull PageToken pageToken) {
+ // TODO: only fetch the properties required for creating an
EntityNameLookupRecord
Review Comment:
To help us remember as well, can we add `and update the underlying
CONSTRAINT clause to make the implicit index INCLUDE the subTypeCode` to this
TODO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
