XN137 commented on code in PR #2317:
URL: https://github.com/apache/polaris/pull/2317#discussion_r2273998626


##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -427,43 +428,28 @@ public Page<EntityNameLookupRecord> listEntities(
       long catalogId,
       long parentId,
       @Nonnull PolarisEntityType entityType,
+      @Nonnull PolarisEntitySubType entitySubType,
       @Nonnull PageToken pageToken) {
+    // TODO: only fetch the properties required for creating an 
EntityNameLookupRecord

Review Comment:
   i'll take a stab at this as an immediate follow-up or file it as a separate 
issue where i will take note of this additional "index coverage" requirement



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to