XN137 commented on code in PR #2304:
URL: https://github.com/apache/polaris/pull/2304#discussion_r2274181092
##########
runtime/service/src/main/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandler.java:
##########
@@ -53,7 +53,7 @@ public boolean handleTask(TaskEntity task, CallContext
callContext) {
BatchFileCleanupTask cleanupTask =
task.readData(BatchFileCleanupTask.class);
TableIdentifier tableId = cleanupTask.tableId();
List<String> batchFiles = cleanupTask.batchFiles();
- try (FileIO authorizedFileIO = fileIOSupplier.apply(task, callContext)) {
+ try (FileIO authorizedFileIO = fileIOSupplier.apply(task, tableId,
callContext)) {
Review Comment:
> In your screenshot, identifier.toString looks correct to me --
cleanup_db1.schema1.table1. Should it be something else?
in the test we are building the `TaskEntity` like so:
https://github.com/apache/polaris/blob/ef177b51cad07411d6b2b673fe3b5cc8a01c6d70/runtime/service/src/test/java/org/apache/polaris/service/task/TableCleanupTaskHandlerTest.java#L110-L112
so the `cleanup_` prefix being in the `TableIdentifier` is not correct.
also a proper `TableIdentifier` would have a non-empty `Namespace` of
`db1.schema1`:
https://github.com/apache/polaris/blob/ef177b51cad07411d6b2b673fe3b5cc8a01c6d70/runtime/service/src/test/java/org/apache/polaris/service/task/TableCleanupTaskHandlerTest.java#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
