adutra commented on code in PR #2290:
URL: https://github.com/apache/polaris/pull/2290#discussion_r2276703908
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -129,6 +132,59 @@ ListEntitiesResult listEntities(
@Nonnull PolarisEntitySubType entitySubType,
@Nonnull PageToken pageToken);
+ /**
+ * Load entities where some predicate returns true and transform the
entities with a function
+ *
+ * @param callCtx call context
+ * @param catalogPath path inside a catalog. If null or empty, the entities
to list are top-level,
Review Comment:
It's unnecessary imho since there is no distinction between what a null list
and an empty list represent, so basically accepting nulls just makes your code
more error prone.
But since other methods exhibit the same behavior, and given that countless
discussions already happened around nullability without us reaching any
conclusion, let's table this topic for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
