XN137 commented on code in PR #2290:
URL: https://github.com/apache/polaris/pull/2290#discussion_r2280312137
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -984,8 +946,14 @@ public List<Catalog> listCatalogs() {
/** List all catalogs without checking for permission. */
private Stream<CatalogEntity> listCatalogsUnsafe() {
- return loadEntities(
- PolarisEntityType.CATALOG, PolarisEntitySubType.ANY_SUBTYPE, null,
CatalogEntity::of);
+ return metaStoreManager
+ .loadEntitiesAll(
+ getCurrentPolarisContext(),
+ null,
+ PolarisEntityType.CATALOG,
+ PolarisEntitySubType.ANY_SUBTYPE,
+ CatalogEntity::of)
Review Comment:
i've pushed a review commit that removes filter+transformer from the
metastoremanager api, as currently its not necessary indeed.
in a followup we should revisit whether the `BasePersistence` api really
needs those params or not but i would prefer to not handle it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
