XN137 commented on code in PR #2381:
URL: https://github.com/apache/polaris/pull/2381#discussion_r2285203195
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -93,6 +93,7 @@ public class TransactionalMetaStoreManagerImpl extends
BaseMetaStoreManager {
private final PolarisDiagnostics diagnostics;
public TransactionalMetaStoreManagerImpl(Clock clock, PolarisDiagnostics
diagnostics) {
+ super(diagnostics);
Review Comment:
sorry i am not following, do you want me to make the field in
`BaseMetaStoreManager` protected and avoid the getter? currently its private
and has a protected getter (as suggested in the other PR).
the thread here is about the existing field in
`TransactionalMetaStoreManagerImpl` which is now kind of redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
