dimas-b commented on code in PR #2381:
URL: https://github.com/apache/polaris/pull/2381#discussion_r2285701600
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java:
##########
@@ -93,6 +93,7 @@ public class TransactionalMetaStoreManagerImpl extends
BaseMetaStoreManager {
private final PolarisDiagnostics diagnostics;
public TransactionalMetaStoreManagerImpl(Clock clock, PolarisDiagnostics
diagnostics) {
+ super(diagnostics);
Review Comment:
I would not mind keeping the `private` field in this class to avoid exposing
fields from the base class.
IMHO, direct field access to the base class in this case will complicate the
work of establishing a "clean" Polaris java API later (soon).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
