fivetran-arunsuri commented on code in PR #2197:
URL: https://github.com/apache/polaris/pull/2197#discussion_r2297898520
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -773,6 +773,49 @@ public PolarisPrincipalSecrets generateNewPrincipalSecrets(
return principalSecrets;
}
+ @Nullable
+ @Override
+ public PolarisPrincipalSecrets resetPrincipalSecrets(
+ @Nonnull PolarisCallContext callCtx,
+ @Nonnull String clientId,
+ long principalId,
+ String customClientId,
+ String customClientSecret) {
+
+ PolarisPrincipalSecrets principalSecrets;
+ if (customClientId == null) {
+ principalSecrets = new PolarisPrincipalSecrets(principalId, clientId,
customClientSecret);
Review Comment:
Sorry I didn't get this, The constructor already generates a random secret
when customClientSecret is null, so we don’t need to handle that separately
here. Please let me know if I’m missing something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
