fivetran-arunsuri commented on code in PR #2197:
URL: https://github.com/apache/polaris/pull/2197#discussion_r2297945882
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -773,6 +773,49 @@ public PolarisPrincipalSecrets generateNewPrincipalSecrets(
return principalSecrets;
}
+ @Nullable
+ @Override
+ public PolarisPrincipalSecrets resetPrincipalSecrets(
+ @Nonnull PolarisCallContext callCtx,
+ @Nonnull String clientId,
+ long principalId,
+ String customClientId,
+ String customClientSecret) {
+
+ PolarisPrincipalSecrets principalSecrets;
+ if (customClientId == null) {
+ principalSecrets = new PolarisPrincipalSecrets(principalId, clientId,
customClientSecret);
+ } else {
+ principalSecrets =
+ new PolarisPrincipalSecrets(principalId, customClientId,
customClientSecret);
+ }
+ try {
+ ModelPrincipalAuthenticationData modelPrincipalAuthenticationData =
+
ModelPrincipalAuthenticationData.fromPrincipalAuthenticationData(principalSecrets);
+ datasourceOperations.executeUpdate(
+ QueryGenerator.generateInsertQuery(
Review Comment:
Made the change as suggested, I am not too sure about passing only 1 client
id as param as they serve their purpose. clientId param is tied to the old
principal and customClientId is user provided clientId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
