jasonf20 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2298473220
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialVendor.java:
##########
@@ -37,6 +38,10 @@ public interface PolarisCredentialVendor {
* allowedWriteLocations
* @param allowedReadLocations a set of allowed to read locations
* @param allowedWriteLocations a set of allowed to write locations
+ * @param refreshCredentialsEndpoint an optional endpoint to use for
refreshing credentials. If
+ * supported by the storage type it will be returned to the client in
the appropriate
+ * properties. The endpoint may be relative to the base URI and the
client is responsible for
Review Comment:
At one point the client required full paths, not it works with partial
paths. I'm not sure if the spec identifies one as the correct method over the
other so I left it like this. If one is definitely the "correct" way I can
update the comment.
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialVendor.java:
##########
@@ -37,6 +38,10 @@ public interface PolarisCredentialVendor {
* allowedWriteLocations
* @param allowedReadLocations a set of allowed to read locations
* @param allowedWriteLocations a set of allowed to write locations
+ * @param refreshCredentialsEndpoint an optional endpoint to use for
refreshing credentials. If
+ * supported by the storage type it will be returned to the client in
the appropriate
+ * properties. The endpoint may be relative to the base URI and the
client is responsible for
Review Comment:
At one point the client required full paths, now it works with partial
paths. I'm not sure if the spec identifies one as the correct method over the
other so I left it like this. If one is definitely the "correct" way I can
update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
