singhpk234 commented on code in PR #2341:
URL: https://github.com/apache/polaris/pull/2341#discussion_r2299364540
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialVendor.java:
##########
@@ -37,6 +38,10 @@ public interface PolarisCredentialVendor {
* allowedWriteLocations
* @param allowedReadLocations a set of allowed to read locations
* @param allowedWriteLocations a set of allowed to write locations
+ * @param refreshCredentialsEndpoint an optional endpoint to use for
refreshing credentials. If
+ * supported by the storage type it will be returned to the client in
the appropriate
+ * properties. The endpoint may be relative to the base URI and the
client is responsible for
Review Comment:
Oh no this made a lot of things super tricky, i checked iceberg python for
refresh keyword but i didn't any prs for that so i am assuming that it doesn't
support, taking only the iceberg java sdk reference
if we always send relative url it only works for >= 1.8
fails for < 1.8
I know there is a header that the java sdk sends which has SDK version
`X-Client-Version` header we may want to salvage this now on when to return the
absolute vs relative,
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/HTTPClient.java#L77
Its a bit surprising to me, but i think for now we can park this by just
documenting this gotcha, WDYT @dimas-b ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
