RussellSpitzer commented on code in PR #1965:
URL: https://github.com/apache/polaris/pull/1965#discussion_r2307816232


##########
runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/JsonEventListener.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.polaris.service.events.jsonEventListener;
+
+import java.util.HashMap;
+import org.apache.polaris.service.events.AfterTableRefreshedEvent;
+import org.apache.polaris.service.events.PolarisEventListener;
+
+/**
+ * Abstract base class from which all event sinks that output events in JSON 
format can extend.
+ *
+ * <p>This class provides a common framework for transforming Polaris events 
into JSON format and
+ * sending them to various destinations. Concrete implementations should 
override the {@link
+ * #transformAndSendEvent(HashMap)} method to define how the JSON event data 
should be transmitted
+ * or stored.
+ */
+public abstract class JsonEventListener extends PolarisEventListener {

Review Comment:
   A note, that I really like having this as a public class because if someone 
does want to write a plugin that doesn't interact with any of the Iceberg or 
other based libraries, they can always utilize this instead and only depend on 
Polaris.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to