XN137 commented on code in PR #2474: URL: https://github.com/apache/polaris/pull/2474#discussion_r2309816832
########## polaris-core/src/main/java/org/apache/polaris/core/DigestUtils.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core; + +import com.google.common.hash.Hashing; +import java.nio.charset.StandardCharsets; + +public final class DigestUtils { + private DigestUtils() { + // utils class + } + + public static String sha256Hex(String input) { + return Hashing.sha256().hashString(input, StandardCharsets.UTF_8).toString(); Review Comment: some basic local testing to confirm this produces the same results as `org.apache.polaris.core.DigestUtils.sha256Hex`: ``` Input: guava -> e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 codec -> e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Input: foobar guava -> c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714caef0c4f2 codec -> c3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714caef0c4f2 Input: ajsdljaksl-92301928i390!@#$%^&*()_+ guava -> ee7a434dd148156b40dd00ad567c37dea7297ebccb6df0f7a5be064c97dcb18b codec -> ee7a434dd148156b40dd00ad567c37dea7297ebccb6df0f7a5be064c97dcb18b Input: 😀 guava -> f0443a342c5ef54783a111b51ba56c938e474c32324d90c3a60c9c8e3a37e2d9 codec -> f0443a342c5ef54783a111b51ba56c938e474c32324d90c3a60c9c8e3a37e2d9 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
