XN137 commented on PR #2474:
URL: https://github.com/apache/polaris/pull/2474#issuecomment-3240812603
thanks for the review
> I would suggest to update LICENSE to remove commons-codec mention there.
i think while this PR removes a direct dependency on the library we still
depend on it transitively and thus it ends up in our binary distribution:
```
unzip -l
./runtime/distribution/build/distributions/polaris-bin-1.1.0-incubating-SNAPSHOT.zip
| grep commons-codec
373045 1980-02-01 00:00
polaris-bin-1.1.0-incubating-SNAPSHOT/admin/lib/main/commons-codec.commons-codec-1.18.0.jar
373045 1980-02-01 00:00
polaris-bin-1.1.0-incubating-SNAPSHOT/server/lib/main/commons-codec.commons-codec-1.18.0.jar
```
doesnt that mean we have to keep it in the LICENSE file?
generally wondering whether we have plans to move towards automatic
creation/update of that file?
i would assume/hope this is a solved problem in the gradle ecosystem
:sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
