flyrain commented on code in PR #2653:
URL: https://github.com/apache/polaris/pull/2653#discussion_r2370731169
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/SchemaVersion.java:
##########
@@ -25,6 +25,8 @@
import org.apache.polaris.persistence.relational.jdbc.DatabaseType;
public class SchemaVersion implements Converter<SchemaVersion> {
+ public static final SchemaVersion MINIMUM = new SchemaVersion(0);
Review Comment:
https://github.com/polaris-catalog/polaris/blob/eb7618bce8b4ecb259f0030d5d24458aa2d91343/persistence/relational-jdbc/src/main/resources/postgres/schema-v1.sql#L26-L26
JDBC impl. is only with the v1 schema. There is no v0 for jdbc
implementations. Should we use `1` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
