eric-maynard commented on code in PR #2653:
URL: https://github.com/apache/polaris/pull/2653#discussion_r2371036168


##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/models/SchemaVersion.java:
##########
@@ -25,6 +25,8 @@
 import org.apache.polaris.persistence.relational.jdbc.DatabaseType;
 
 public class SchemaVersion implements Converter<SchemaVersion> {
+  public static final SchemaVersion MINIMUM = new SchemaVersion(0);

Review Comment:
   I believe that's why we want to use 0 -- the v1 schema file includes the 
VERSION table, so the lack of a VERSION table indicates an earlier (pre-1) 
schema.
   
   We don't use this MINIMUM number to choose a schema file, only the reverse 
-- the detect what schema version an already-running metastore was bootstrapped 
with.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to