dimas-b commented on code in PR #2672:
URL: https://github.com/apache/polaris/pull/2672#discussion_r2383277570
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -98,6 +98,18 @@ public URI getInternalEndpointUri() {
/** Flag indicating whether path-style bucket access should be forced in S3
clients. */
public abstract @Nullable Boolean getPathStyleAccess();
+ /**
+ * Flag indicating whether STS is available or not. It is modeled in the
negative to simplify
+ * support for unset values ({@code null} being interpreted as {@code
false}).
Review Comment:
Javadoc is correct, I believe 😅 A null (unset) value would be treated
`StsUnavailable` being `false` , meaning that STS is _available_ (current
default).
I believe interpreting `null` as `false` is quite common.
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -98,6 +98,18 @@ public URI getInternalEndpointUri() {
/** Flag indicating whether path-style bucket access should be forced in S3
clients. */
public abstract @Nullable Boolean getPathStyleAccess();
+ /**
+ * Flag indicating whether STS is available or not. It is modeled in the
negative to simplify
+ * support for unset values ({@code null} being interpreted as {@code
false}).
Review Comment:
Javadoc is correct, I believe 😅 A null (unset) value would be treated as
`StsUnavailable` being `false` , meaning that STS is _available_ (current
default).
I believe interpreting `null` as `false` is quite common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
