flyrain commented on code in PR #2672:
URL: https://github.com/apache/polaris/pull/2672#discussion_r2383382532
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -98,6 +98,18 @@ public URI getInternalEndpointUri() {
/** Flag indicating whether path-style bucket access should be forced in S3
clients. */
public abstract @Nullable Boolean getPathStyleAccess();
+ /**
+ * Flag indicating whether STS is available or not. It is modeled in the
negative to simplify
+ * support for unset values ({@code null} being interpreted as {@code
false}).
Review Comment:
You are right, sorry for the misleading. I was confused by two new methods
introduced, `getStsUnavailable()`, `shouldUseSts()`, I think it'd be nice to
only keep one of them. For example, the check brought up by @singhpk234 here
https://github.com/apache/polaris/pull/2672#discussion_r2383187673, would be
reasonable to apply when we check `getStsUnavailable()` purely. Wrapping
`getStsUnavailable()` with `shouldUseSts()` makes it even more ambiguous, so
that the logic become less obviously when we need to check if users ask for
credential vending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
