dimas-b commented on code in PR #2735:
URL: https://github.com/apache/polaris/pull/2735#discussion_r2399795988
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1566,14 +1566,19 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
"Generic table with same name already exists: %s",
tableIdentifier);
}
}
+ Map<String, String> storedProperties =
buildTableMetadataPropertiesMap(metadata);
IcebergTableLikeEntity entity =
IcebergTableLikeEntity.of(resolvedPath == null ? null :
resolvedPath.getRawLeafEntity());
String existingLocation;
if (null == entity) {
existingLocation = null;
entity =
new IcebergTableLikeEntity.Builder(
- PolarisEntitySubType.ICEBERG_TABLE, tableIdentifier,
newLocation)
+ PolarisEntitySubType.ICEBERG_TABLE,
+ tableIdentifier,
+ Map.of(),
Review Comment:
nit: If we're using the builder pattern, why have rich constructor
parameters? Why not call `.setABC()`?
In this case the `Map` is empty, so this parameter is redundant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
