HonahX commented on code in PR #2735:
URL: https://github.com/apache/polaris/pull/2735#discussion_r2404179740
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogTest.java:
##########
@@ -2283,6 +2287,96 @@ public void
testTableOperationsDoesNotRefreshAfterCommit(boolean updateMetadataO
}
}
+ @Test
+ public void testTableInternalPropertiesStoredOnCommit() {
+ Assumptions.assumeTrue(
+ requiresNamespaceCreate(),
+ "Only applicable if namespaces must be created before adding
children");
+
+ catalog.createNamespace(NS);
+ catalog.buildTable(TABLE, SCHEMA).create();
+ catalog.loadTable(TABLE).newFastAppend().appendFile(FILE_A).commit();
+ Table afterAppend = catalog.loadTable(TABLE);
+ EntityResult schemaResult =
Review Comment:
```suggestion
EntityResult namespaceResult =
```
[nit] Let's use `namespace` here to be consistent with polaris' terminology
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogTest.java:
##########
@@ -2283,6 +2287,96 @@ public void
testTableOperationsDoesNotRefreshAfterCommit(boolean updateMetadataO
}
}
+ @Test
+ public void testTableInternalPropertiesStoredOnCommit() {
Review Comment:
[Non-blocker] Since we are testing the extraction of metadata fields, it
would be good if we could add/or parametrize this test with different
format-version (1,2,3). Technically the `TableMetadata` should be
format-version agnostic, but a sanity check would be useful in case there's
some upstream bug : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
