XJDKC commented on code in PR #2759: URL: https://github.com/apache/polaris/pull/2759#discussion_r2411310032
########## runtime/service/src/main/java/org/apache/polaris/service/credentials/connection/SigV4ConnectionCredentialVendor.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.credentials.connection; + +import com.google.common.annotations.VisibleForTesting; +import jakarta.annotation.Nonnull; +import jakarta.annotation.Priority; +import jakarta.enterprise.context.ApplicationScoped; +import jakarta.inject.Inject; +import java.util.Optional; +import org.apache.polaris.core.connection.AuthenticationType; +import org.apache.polaris.core.connection.ConnectionConfigInfoDpo; +import org.apache.polaris.core.connection.SigV4AuthenticationParametersDpo; +import org.apache.polaris.core.credentials.connection.CatalogAccessProperty; +import org.apache.polaris.core.credentials.connection.ConnectionCredentialVendor; +import org.apache.polaris.core.credentials.connection.ConnectionCredentials; +import org.apache.polaris.core.identity.credential.AwsIamServiceIdentityCredential; +import org.apache.polaris.core.identity.credential.ServiceIdentityCredential; +import org.apache.polaris.core.identity.provider.ServiceIdentityProvider; +import org.apache.polaris.core.storage.aws.StsClientProvider; +import software.amazon.awssdk.services.sts.StsClient; +import software.amazon.awssdk.services.sts.model.AssumeRoleRequest; +import software.amazon.awssdk.services.sts.model.AssumeRoleResponse; + +/** + * Connection credential vendor for AWS SigV4 authentication. + * + * <p>This vendor uses Polaris's AWS IAM service identity to assume a customer-provided IAM role via + * AWS STS, generating temporary credentials that Polaris uses to access external AWS services + * (e.g., AWS Glue catalog) with SigV4 request signing. + * + * <p>Flow: + * + * <ol> + * <li>Receives Polaris's {@link AwsIamServiceIdentityCredential} (the IAM user/role Polaris owns) + * <li>Extracts customer's role ARN from {@link SigV4AuthenticationParametersDpo} + * <li>Calls AWS STS AssumeRole to get temporary credentials + * <li>Returns temporary access key, secret key, and session token + * </ol> + * + * <p>This is the default implementation with {@code @Priority(100)}. Custom implementations can + * override this by providing a higher priority value. + */ +@ApplicationScoped +@AuthType(AuthenticationType.SIGV4) +@Priority(100) +public class SigV4ConnectionCredentialVendor implements ConnectionCredentialVendor { + + private final StsClientProvider stsClientProvider; + private final ServiceIdentityProvider serviceIdentityProvider; + + @Inject + public SigV4ConnectionCredentialVendor( + StsClientProvider stsClientProvider, ServiceIdentityProvider serviceIdentityProvider) { + this.stsClientProvider = stsClientProvider; + this.serviceIdentityProvider = serviceIdentityProvider; + } + + @Override + public @Nonnull ConnectionCredentials getConnectionCredentials( + @Nonnull ConnectionConfigInfoDpo connectionConfig) { + + // Resolve the service identity credential + Optional<ServiceIdentityCredential> serviceCredentialOpt = + serviceIdentityProvider.getServiceIdentityCredential(connectionConfig.getServiceIdentity()); + if (serviceCredentialOpt.isEmpty()) { + return ConnectionCredentials.builder().build(); + } + + // Cast to expected types for SigV4 + AwsIamServiceIdentityCredential awsCredential = + (AwsIamServiceIdentityCredential) serviceCredentialOpt.get(); + SigV4AuthenticationParametersDpo sigv4Params = + (SigV4AuthenticationParametersDpo) connectionConfig.getAuthenticationParameters(); + + // Use Polaris's IAM identity to assume the customer's role + StsClient stsClient = getStsClient(sigv4Params); + + // Build the AssumeRole request with Polaris's credentials + AssumeRoleRequest.Builder requestBuilder = + AssumeRoleRequest.builder() + .roleArn(sigv4Params.getRoleArn()) + .roleSessionName( Review Comment: Good point, since we don't vend / return this credentials to the client, so it should be fine. For the `simple` approach, we need to use different service-level scoping policy for different services (based on the sigv4 signing name). e.g., if the service is * `glue` we need to get `glue:ListTables`, ``glue:ListDatabases`, e.t.c, * We may also need some privileges on Lake Formation so that we can get the vended credentials, if we want to use the vended credentials to load table metadata rather than using the storage config. * `execute-api` (api gateway), we need to use `execute-api:Invoke` * `s3tables`: we need another set of privileges. I will add a TODO for now since I need to spend some time to figure out the correct policy string for each service. We may need a refactor on the policy generation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
