XN137 commented on code in PR #2555:
URL: https://github.com/apache/polaris/pull/2555#discussion_r2416139337
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -196,52 +188,46 @@ public Map<String, BaseResult>
purgeRealms(Iterable<String> realms) {
for (String realm : realms) {
RealmContext realmContext = () -> realm;
- PolarisMetaStoreManager metaStoreManager =
getOrCreateMetaStoreManager(realmContext);
- BasePersistence session = getOrCreateSession(realmContext);
+ PolarisMetaStoreManager metaStoreManager =
createMetaStoreManager(realmContext, null);
- PolarisCallContext callContext = new PolarisCallContext(realmContext,
session);
- BaseResult result = metaStoreManager.purge(callContext);
+ BaseResult result = metaStoreManager.purge();
results.put(realm, result);
sessionSupplierMap.remove(realm);
- metaStoreManagerMap.remove(realm);
}
return Map.copyOf(results);
}
@Override
- public synchronized PolarisMetaStoreManager getOrCreateMetaStoreManager(
- RealmContext realmContext) {
- if (!metaStoreManagerMap.containsKey(realmContext.getRealmIdentifier())) {
- DatasourceOperations datasourceOperations = getDatasourceOperations();
- initializeForRealm(datasourceOperations, realmContext, null);
- checkPolarisServiceBootstrappedForRealm(realmContext);
+ public PolarisMetaStoreManager createMetaStoreManager(
+ RealmContext realmContext, @Nullable RealmConfig realmConfig) {
+ if (realmConfig == null) {
+ realmConfig = new RealmConfigImpl(configurationStore, realmContext);
Review Comment:
as we can build it ourselves its not strictly needed no, but many call sites
already have it and can pass it in.
i am fine to remove the parameter if we think thats better overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
