XN137 commented on code in PR #2555:
URL: https://github.com/apache/polaris/pull/2555#discussion_r2416152818
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/InMemoryEntityCache.java:
##########
@@ -43,19 +42,12 @@
public class InMemoryEntityCache implements EntityCache {
private final PolarisDiagnostics diagnostics;
- private final PolarisMetaStoreManager polarisMetaStoreManager;
Review Comment:
afaict we cant keep this field as `PolarisMetaStoreManager` now represents a
(per-request) persistence session where-as `InMemoryEntityCache` is supposed to
be a shared cache within a realm.
the question is with what persistence session do we want to populate the
cache?
a shared one or the request-scoped one given by the callers as "use this for
loading in case cache entry is missing" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
