XJDKC commented on code in PR #2759: URL: https://github.com/apache/polaris/pull/2759#discussion_r2411890987
########## runtime/service/src/main/java/org/apache/polaris/service/credentials/PolarisCredentialManagerConfiguration.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.credentials; + +import io.quarkus.runtime.annotations.StaticInitSafe; +import io.smallrye.config.ConfigMapping; +import org.apache.polaris.core.credentials.PolarisCredentialManager; + +/** + * Quarkus configuration mapping for Polaris Credential Manager. + * + * <p>Defines which {@link PolarisCredentialManager} implementation should be used at runtime. This + * allows switching between different credential management strategies via configuration. + */ +@StaticInitSafe +@ConfigMapping(prefix = "polaris.credential-manager") +public interface PolarisCredentialManagerConfiguration { + + /** + * The type identifier of the PolarisCredentialManager implementation to use. This corresponds to + * the {@code @Identifier} annotation value on the implementation (e.g., "default"). + */ + String type(); Review Comment: Explicitly defining a config property has some benefits: it gives us a dedicated top-level class to hold the property, rather than relying on conventions defined in the producer classes. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
