XJDKC commented on code in PR #2759:
URL: https://github.com/apache/polaris/pull/2759#discussion_r2408938016


##########
runtime/service/src/main/java/org/apache/polaris/service/credentials/connection/SigV4ConnectionCredentialVendor.java:
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.credentials.connection;
+
+import com.google.common.annotations.VisibleForTesting;
+import jakarta.annotation.Nonnull;
+import jakarta.annotation.Priority;
+import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.inject.Inject;
+import java.util.Optional;
+import org.apache.polaris.core.connection.AuthenticationType;
+import org.apache.polaris.core.connection.ConnectionConfigInfoDpo;
+import org.apache.polaris.core.connection.SigV4AuthenticationParametersDpo;
+import 
org.apache.polaris.core.credentials.connection.ConnectionCredentialProperty;
+import 
org.apache.polaris.core.credentials.connection.ConnectionCredentialVendor;
+import org.apache.polaris.core.credentials.connection.ConnectionCredentials;
+import 
org.apache.polaris.core.identity.credential.AwsIamServiceIdentityCredential;
+import org.apache.polaris.core.identity.credential.ServiceIdentityCredential;
+import org.apache.polaris.core.identity.provider.ServiceIdentityProvider;
+import org.apache.polaris.core.storage.aws.StsClientProvider;
+import software.amazon.awssdk.services.sts.StsClient;
+import software.amazon.awssdk.services.sts.model.AssumeRoleRequest;
+import software.amazon.awssdk.services.sts.model.AssumeRoleResponse;
+
+/**
+ * Connection credential vendor for AWS SigV4 authentication.
+ *
+ * <p>This vendor uses Polaris's AWS IAM service identity to assume a 
customer-provided IAM role via
+ * AWS STS, generating temporary credentials that Polaris uses to access 
external AWS services
+ * (e.g., AWS Glue catalog) with SigV4 request signing.
+ *
+ * <p>Flow:
+ *
+ * <ol>
+ *   <li>Receives Polaris's {@link AwsIamServiceIdentityCredential} (the IAM 
user/role Polaris owns)
+ *   <li>Extracts customer's role ARN from {@link 
SigV4AuthenticationParametersDpo}
+ *   <li>Calls AWS STS AssumeRole to get temporary credentials
+ *   <li>Returns temporary access key, secret key, and session token
+ * </ol>
+ *
+ * <p>This is the default implementation with {@code @Priority(100)}. Custom 
implementations can
+ * override this by providing a higher priority value.
+ */
+@ApplicationScoped
+@SupportsAuthType(AuthenticationType.SIGV4)

Review Comment:
   Done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to