HonahX commented on code in PR #2782:
URL: https://github.com/apache/polaris/pull/2782#discussion_r2422215071
##########
runtime/service/src/main/java/org/apache/polaris/service/credentials/connection/SigV4ConnectionCredentialVendor.java:
##########
@@ -58,7 +58,7 @@
* <p>This is the default implementation with {@code @Priority(100)}. Custom
implementations can
* override this by providing a higher priority value.
*/
-@ApplicationScoped
+@RequestScoped
Review Comment:
> Referencing an application-scoped object from a request scope is usually ok
I think in case of the SigV4ConenctionCredentialVendor is the reverse? That
an application-scoped object referencing a request-scoped one. The
request-scoped one will always be empty or contain wrong context I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
