XJDKC commented on code in PR #2782:
URL: https://github.com/apache/polaris/pull/2782#discussion_r2421952242
##########
polaris-core/src/main/java/org/apache/polaris/core/credentials/connection/CatalogAccessProperty.java:
##########
@@ -28,15 +29,23 @@
* Catalog service.
*/
public enum CatalogAccessProperty {
+ // OAuth
+ OAUTH2_CREDENTIAL(String.class, OAuth2Properties.CREDENTIAL, "the OAuth2
credential", true),
+
+ // Bearer
+ BEARER_TOKEN(String.class, OAuth2Properties.TOKEN, "the bearer token", true),
+
+ // SigV4
AWS_ACCESS_KEY_ID(String.class, AwsProperties.REST_ACCESS_KEY_ID, "the aws
access key id", true),
AWS_SECRET_ACCESS_KEY(
- String.class, AwsProperties.REST_SECRET_ACCESS_KEY, "the aws access key
secret", true),
- AWS_SESSION_TOKEN(
- String.class, AwsProperties.REST_SESSION_TOKEN, "the aws scoped access
token", true),
+ String.class, AwsProperties.REST_SECRET_ACCESS_KEY, "the aws secret
access key", true),
+ AWS_SESSION_TOKEN(String.class, AwsProperties.REST_SESSION_TOKEN, "the aws
session token", true),
+
+ // Metadata
EXPIRATION_TIME(
Review Comment:
Revised the `CatalogAccessProperty` a bit, follow the pattern in
`StorageAccessCredential`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
