XJDKC commented on code in PR #2759: URL: https://github.com/apache/polaris/pull/2759#discussion_r2415046178
########## runtime/service/src/main/java/org/apache/polaris/service/credentials/DefaultPolarisCredentialManager.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.credentials; + +import io.smallrye.common.annotation.Identifier; +import jakarta.annotation.Nonnull; +import jakarta.enterprise.context.RequestScoped; +import jakarta.enterprise.inject.Any; +import jakarta.enterprise.inject.Instance; +import jakarta.inject.Inject; +import org.apache.polaris.core.connection.AuthenticationType; +import org.apache.polaris.core.connection.ConnectionConfigInfoDpo; +import org.apache.polaris.core.context.RealmContext; +import org.apache.polaris.core.credentials.PolarisCredentialManager; +import org.apache.polaris.core.credentials.connection.ConnectionCredentialVendor; +import org.apache.polaris.core.credentials.connection.ConnectionCredentials; +import org.apache.polaris.service.credentials.connection.AuthType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Default implementation of {@link PolarisCredentialManager} responsible for retrieving credentials + * used by Polaris to access external systems such as remote catalogs or cloud storage. + * + * <p>This implementation delegates to {@link ConnectionCredentialVendor} implementations selected + * via CDI based on the authentication type. Each vendor handles the credential transformation logic + * for a specific authentication mechanism (e.g., SigV4, OAuth). + * + * <p>This bean is request-scoped and realm-aware, delegating all credential generation to + * CDI-managed vendors. + * + * <p>Flow: + * + * <ol> + * <li>Selects the appropriate {@link ConnectionCredentialVendor} based on the authentication type + * <li>Delegates to the vendor to generate the final connection credentials (the vendor will + * resolve the service identity internally) + * </ol> + */ +@RequestScoped +@Identifier("default") +public class DefaultPolarisCredentialManager implements PolarisCredentialManager { + private static final Logger LOGGER = + LoggerFactory.getLogger(DefaultPolarisCredentialManager.class); + + private final RealmContext realmContext; + private final Instance<ConnectionCredentialVendor> credentialVendors; + + @Inject + public DefaultPolarisCredentialManager( + RealmContext realmContext, @Any Instance<ConnectionCredentialVendor> credentialVendors) { + this.realmContext = realmContext; + this.credentialVendors = credentialVendors; + } + + public RealmContext getRealmContext() { + return realmContext; + } + + @Override + public @Nonnull ConnectionCredentials getConnectionCredentials( + @Nonnull ConnectionConfigInfoDpo connectionConfig) { + + // Select the appropriate vendor based on authentication type + AuthenticationType authType = + connectionConfig.getAuthenticationParameters().getAuthenticationType(); + Instance<ConnectionCredentialVendor> selectedVendor = + credentialVendors.select(AuthType.Literal.of(authType)); + + if (selectedVendor.isUnsatisfied()) { + // TODO: Add credential vendors for other authentication types + LOGGER.warn("No connection credential vendor found for authentication type: {}", authType); + return ConnectionCredentials.builder().build(); + } + + if (selectedVendor.isAmbiguous()) { + LOGGER.error( + "Multiple connection credential vendors found for authentication type: {}. " + + "Use @Priority to specify which vendor should be used. " + + "Higher priority values take precedence.", + authType); + throw new IllegalStateException( + String.format( + "Ambiguous connection credential vendor for authentication type: %s. " + + "Multiple implementations found without @Priority annotation.", + authType)); + } + + // Delegate to the vendor to generate credentials + return selectedVendor.get().getConnectionCredentials(connectionConfig); Review Comment: Yes, this can't be resolved in CDI, but why do we make things very complicated. With this approach, when we want to get the `DefaultPolarisCredentialManager`, we need to filter based on `Qualifier`. When we want to get the specific vendor, we need to filter based on `@AuthType`. ```java @Produces @RequestScoped public ConnectionCredentialVendor connectionCredentialVendor( PolarisCredentialManagerConfiguration config, @Any Instance<PolarisCredentialManager> credentialManagers) { return (ConnectionCredentialVendor) credentialManagers.select(Identifier.Literal.of(config.type())).get(); } @Produces @RequestScoped public StorageCredentialVendor storageCredentialVendor( PolarisCredentialManagerConfiguration config, @Any Instance<PolarisCredentialManager> credentialManagers) { return (StorageCredentialVendor) credentialManagers.select(Identifier.Literal.of(config.type())).get(); } ``` Why not just add a new interface that implements all the credential vendors? That way, whenever we need credentials, we can simply use `PolarisCredentialManager`. It's cleaner and doesn't introduce any downside. If vendors want to provide their own `DefaultPolarisCredentialManager`, they don't need to understand the underlying mechanism and also follow this pattern. (i.e., providing two producers and return different vendor type). And the callers also needs to understand that the one they are using is not the specific `ConnectionCredentialVendor` but the `DefaultPolarisCredentialManager` which has the cache logic and the multiplexing logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
