flyrain commented on code in PR #2728: URL: https://github.com/apache/polaris/pull/2728#discussion_r2446240028
########## persistence/nosql/nodes/api/src/main/java/org/apache/polaris/nodes/api/Node.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.nodes.api; Review Comment: > Hm, not sure I understand your cite of the get an overview of the active processes use case and question about another use case. The citation probably doesn't quite matter. I was trying to understand the node id generator use cases beyond snowflake id. > As a side benefit of maintaining a list of active node IDs, one can use that information to report the status of Polaris JVMs that allocate those node IDs. However, this is completely at the discretion of downstream projects that include Polaris libraries. Thanks, Dmitri! This feels more like a K8s-level concern rather than something at the application level (referring to the Polaris service). Could you shed some light on how downstream projects make use of these node IDs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
