dennishuo commented on code in PR #2728: URL: https://github.com/apache/polaris/pull/2728#discussion_r2470726123
########## persistence/nosql/nodes/api/src/main/java/org/apache/polaris/nodes/api/Node.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.nodes.api; Review Comment: Generally I agree with @flyrain about starting with more constrained package names where possible, not because we're necessarily implying that the concepts within the package can't be useful in other use cases, but because it's best to be more "deliberate" when adopting the libraries into those other use cases, where we'll be able to better assess the suitability of which aspects constitute a stable SPI, whether there are pitfalls to document better, etc. I do think the `nodeids` package name is at least an improvement over the more general `nodes` at this stage though, so maybe that's enough for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
