MonkeyCanCode commented on code in PR #2812:
URL: https://github.com/apache/polaris/pull/2812#discussion_r2488340220
##########
client/python/apache_polaris/cli/polaris_cli.py:
##########
@@ -50,29 +50,29 @@ class PolarisCli:
def _patch_generated_models() -> None:
"""
The OpenAPI generator creates an `api_client` that dynamically looks up
- model classes from the `polaris.catalog.models` module using
`getattr()`.
+ model classes from the `apache_polaris.sdk.catalog.models` module
using `getattr()`.
For example, when a response for a `create_policy` call is received,
the
deserializer tries to find the `LoadPolicyResponse` class by looking
for
- `polaris.catalog.models.LoadPolicyResponse`.
+ `apache_polaris.sdk.catalog.models.LoadPolicyResponse`.
However, the generator fails to add the necessary `import` statements
to the `polaris/catalog/models/__init__.py` file. This means that even
Review Comment:
@binarycat0 mind update here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
