MonkeyCanCode commented on PR #2812: URL: https://github.com/apache/polaris/pull/2812#issuecomment-3483307116
> Hello @MonkeyCanCode 👋, thank you for the review. I fixed the mentioned NIT comments, thanks. > > Also, the mentioned string splitters by () is caused by automatically formatting or by `make client-lint` command. If the `make client-lint` command does not contain the black formatting, I would propose implement it there. > > In my experience an applying "isort + mypy + black" linting was by default, I would like suggest following the same standard as many python projects. > > > > Hello, sorry for the delay. I will check this weekend. > > > > @MonkeyCanCode @HonahX Hello colleagues. Please review. Thx 🙏 > > > > > > @binarycat0 nice work and thanks for the coordination on the dev ML. Thanks for the quick fix. One of the minor comment was not fixed. Other than that, this looks good to me. @eric-maynard @HonahX , do u mind also take a look when u have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
