adutra commented on code in PR #2972: URL: https://github.com/apache/polaris/pull/2972#discussion_r2494164065
########## runtime/service/src/main/java/org/apache/polaris/service/context/catalog/PolarisCallContextCatalogFactory.java: ########## @@ -39,7 +39,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -@ApplicationScoped +@RequestScoped Review Comment: A general remark: just because a CDI bean is being injected request-scoped beans, doesn't mean the bean itself must switch to request scope. All is needed is that the request scope must be active when any of the injected request-scoped beans is accessed. Here for instance, this is the case, so keeping `@ApplicationScoped` doesn't hurt. I tried, and all tests passed. Keeping application scope whenever possible reduces the number of proxies created for each request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
