dimas-b commented on code in PR #2972: URL: https://github.com/apache/polaris/pull/2972#discussion_r2494590856
########## runtime/service/src/main/java/org/apache/polaris/service/context/catalog/PolarisCallContextCatalogFactory.java: ########## @@ -39,7 +39,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -@ApplicationScoped +@RequestScoped Review Comment: Injecting request-scoped `PolarisPrincipal` into an `@ApplicationScoped` bean will work in Quarkus, but the injected object will be a proxy, switching to the active context in runtime. From my POV making this bean `@RequestScoped` is nicer because it makes bean grouping more explicit and this bean does not have to keep any global state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
