adutra commented on code in PR #2983:
URL: https://github.com/apache/polaris/pull/2983#discussion_r2494772794
##########
helm/polaris/templates/_helpers.tpl:
##########
@@ -142,7 +142,7 @@ line breaks, they will be escaped and a multi-line option
will be printed.
{{- $value := index . 1 -}}
{{- $global := index . 2 -}}
{{- $valAsString := "" -}}
-{{- if ne $value nil -}}
+{{- if $value -}}
Review Comment:
We really want this to be `if ne $value nil`. This is unusual, I know, but
here we need to distinguish other zero-values from nil. For example, `foo:
false` or `foo: 0` should result in the config property `foo` being included in
the ConfigMap, with value `false` or `0`.
If we change this as you suggested, these properties would not be included.
Taking a step back, can you show us a test case that is currently failing?
This would help us understand your issue and fix it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
