cccs-cat001 commented on code in PR #2983:
URL: https://github.com/apache/polaris/pull/2983#discussion_r2494846559
##########
helm/polaris/templates/_helpers.tpl:
##########
@@ -142,7 +142,7 @@ line breaks, they will be escaped and a multi-line option
will be printed.
{{- $value := index . 1 -}}
{{- $global := index . 2 -}}
{{- $valAsString := "" -}}
-{{- if ne $value nil -}}
+{{- if $value -}}
Review Comment:
I really have no idea what values it was failing on. Helm has been pretty
useless in telling me where it went wrong.
```
Error: template: catalog/charts/polaris/templates/configmap.yaml:216:7:
executing "catalog/charts/polaris/templates/configmap.yaml" at <include
"polaris.appendConfigOption" (list $k $v $global)>: error calling include:
template: catalog/charts/polaris/templates/_helpers.tpl:145:7: executing
"polaris.appendConfigOption" at <ne $value nil>: error calling ne: incompatible
types for comparison
helm.go:81: [debug] template:
catalog/charts/polaris/templates/configmap.yaml:216:7: executing
"catalog/charts/polaris/templates/configmap.yaml" at <include
"polaris.appendConfigOption" (list $k $v $global)>: error calling include:
template: catalog/charts/polaris/templates/_helpers.tpl:145:7: executing
"polaris.appendConfigOption" at <ne $value nil>: error calling ne: incompatible
types for comparison
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
